Changeset 257 for trunk/lib

Timestamp:

06/16/11 20:13:13 (14 years ago)

Author:

tim

Message:

documentation fixes/additions

Location:

trunk/lib

Files:

• regfi.c (modified) (7 diffs)
• winsec.c (modified) (1 diff)

trunk/lib/regfi.c

@@ -1997 +1997 @@
   cur_key = regfi_iterator_cur_key(i);
   if(cur_key == NULL)
-    /* XXX: report error */
+    regfi_log_add(REGFI_LOG_ERROR, "Current key invalid in find_subkey.");
     return ret_val;
 
@@ -2100 +2100 @@
   cur_key = regfi_iterator_cur_key(i);
   if(cur_key == NULL)
-    /* XXX: report error */
+    regfi_log_add(REGFI_LOG_ERROR, "Current key invalid in cur_subkey.");
     return NULL;
 
@@ -2129 +2129 @@
   cur_key = regfi_iterator_cur_key(i);
   if(cur_key == NULL)
-    /* XXX: report error */
+    regfi_log_add(REGFI_LOG_ERROR, "Current key invalid in find_value.");
     return ret_val;
 
@@ -2161 +2161 @@
   cur_key = regfi_iterator_cur_key(i);
   if(cur_key == NULL)
-    /* XXX: report error */
+    regfi_log_add(REGFI_LOG_ERROR, "Current key invalid in cur_value.");
     return ret_val;
 
@@ -2523 +2523 @@
     }
 
-    /* XXX: check for NULL */
     tmp_str = talloc_realloc(NULL, tmp_str, uint8_t, tmp_size);
+    if(tmp_str == NULL)
+      return false;
     data->interpreted.string = tmp_str;
     data->interpreted_size = tmp_size;
@@ -2770 +2771 @@
   memcpy(ret_val->file_name, file_header+0x30,  REGFI_REGF_NAME_SIZE);
 
-  /* XXX: Should we add a warning if these uuid parsers fail?  Can they? */
   ret_val->rm_id = winsec_parse_uuid(ret_val, file_header+0x70, 16);
+  if(ret_val->rm_id == NULL)
+    regfi_log_add(REGFI_LOG_WARN, "Hive header's rm_id failed to parse.");
+
   ret_val->log_id = winsec_parse_uuid(ret_val, file_header+0x80, 16);
+  if(ret_val->log_id == NULL)
+    regfi_log_add(REGFI_LOG_WARN, "Hive header's log_id failed to parse.");
+
   ret_val->flags = IVAL(file_header, 0x90);
+
   ret_val->tm_id = winsec_parse_uuid(ret_val, file_header+0x94, 16);
+  if(ret_val->tm_id == NULL)
+    regfi_log_add(REGFI_LOG_WARN, "Hive header's tm_id failed to parse.");
+
   ret_val->guid_signature = IVAL(file_header, 0xa4);
 
@@ -3486 +3496 @@
 
   /* XXX: do something with unalloc? */
-
   max_size = regfi_calc_maxsize(file, offset);
   if((max_size < 0) || (num_chunks*sizeof(uint32_t) + 4 > max_size))

trunk/lib/winsec.c

@@ -62 +62 @@
   ret_val->control = SVAL(buf, 0x2);
 
+  /* XXX: should probably reject any non-self relative */
   if(!(ret_val->control & WINSEC_DESC_SELF_RELATIVE))
     fprintf(stderr, "DEBUG: NOT self-relative!\n");