Changeset 200

Timestamp:

06/03/10 01:08:20 (14 years ago)

Author:

tim

Message:

redesigned python key iterator and test script
updated documentation

Files:

• test/pyregfi-smoketest.py (modified) (1 diff)
• trunk/include/regfi.h (modified) (4 diffs)
• trunk/lib/regfi.c (modified) (1 diff)
• trunk/python2/regfi/pyregfi.h (modified) (3 diffs)
• trunk/python2/regfi/regfi.c (modified) (8 diffs)

test/pyregfi-smoketest.py

@@ -15 +15 @@
 
 
-def walk_tree(iter):
-    total_keys = 1
-    total_values = iter_values(iter)
-    print "total_values:", total_values
-    
-    for sub_key in iter:
-        print sub_key.keyname
-        
-        print iter.down()
-        num_keys,num_values = walk_tree(iter)
-        total_keys += num_keys
-        total_values += num_values
-        iter.up()
-
-    return (total_keys, total_values)
-
-
 for f in files:
     rf = pyregfi.RegistryFile(f)
     iter = rf.get_key()
-    print walk_tree(iter)
+
+    num_keys = 0
+    num_values = 0
+    # The iterator now walks the entire registry hive, depth-first
+    for key in iter:
+        #print key.keyname
+        num_keys +=1
+        num_values += iter_values(iter)
+
+    print "keys: %d" % num_keys
+    print "values: %d" % num_values

trunk/include/regfi.h

@@ -1067 +1067 @@
 
 /** Sets the internal subkey index to the first subkey referenced by the current
- *  key and returns that key.
+ *  key.
  *
  * @param i the iterator
  *
- * @return A newly allocated key structure for the newly referenced first 
- *         subkey, or NULL on failure.  Failure may be due to a lack of any
- *         subkeys or other errors.  Newly allocated keys must be freed with
- *         @ref regfi_free_record.
+ * @return True if the current key has any subkeys, false otherwise.
  *
  * @ingroup regfiIteratorLayer
@@ -1094 +1091 @@
 
 
-/** Increments the internal subkey index to the next key in the subkey-list and
- *  returns the subkey for that index.
+/** Increments the internal subkey index to the next key in the subkey-list.
  *
  * @param i the iterator
  *
- * @return A newly allocated key structure for the next subkey or NULL on
- *         failure.  Newly allocated keys must be freed with 
- *         @ref regfi_free_record.
+ * @return True if another subkey should exist, false otherwise.
  *
  * @ingroup regfiIteratorLayer
@@ -1123 +1117 @@
 
 /** Sets the internal value index to the first value referenced by the current
- *  key and returns that value.
+ *  key.
  *
  * @param i the iterator
  *
- * @return  A newly allocated value structure for the newly referenced first
- *          value, or NULL on failure.  Failure may be due to a lack of any
- *          values or other errors.  Newly allocated keys must be freed with
- *          @ref regfi_free_record.
+ * @return True if the current key has any values, false otherwise.
  *
  * @ingroup regfiIteratorLayer
@@ -1150 +1141 @@
 
 
-/** Increments the internal value index to the next value in the value-list and
- *  returns the value for that index.
+/** Increments the internal value index to the next value in the value-list.
  *
  * @param i the iterator
  *
- * @return  A newly allocated key structure for the next value or NULL on 
- *          failure.  Newly allocated keys must be freed with 
- *          @ref regfi_free_record.
+ * @return True if another value should exist, false otherwise.
  *
  * @ingroup regfiIteratorLayer

trunk/lib/regfi.c

@@ -67 +67 @@
 void regfi_init()
 {
+fprintf(stderr, "regfi_init called\n");
   int err;
   if((err = pthread_key_create(&regfi_log_key, regfi_log_free)) != 0)

trunk/python2/regfi/pyregfi.h

@@ -49 +49 @@
 CLASS(KeyIterator, Object)
      PRIVATE REGFI_ITERATOR *iter;
-     PRIVATE bool first_called;
+     PRIVATE bool root_traversed;
 
      KeyIterator METHOD(KeyIterator, Con, struct RegistryFile_t *file, char **path,
@@ -56 +56 @@
      struct ValueIterator_t *METHOD(KeyIterator, list_values);
 
-     KeyIterator METHOD(KeyIterator, __iter__);
-     REGFI_NK_REC *METHOD(KeyIterator, iternext);
+     void METHOD(KeyIterator, __iter__);
+     BORROWED REGFI_NK_REC *METHOD(KeyIterator, iternext);
 
      int METHOD(KeyIterator, down);
@@ -71 +71 @@
 
      void METHOD(ValueIterator, __iter__);
-     RawData METHOD(ValueIterator, iternext);
+     REGFI_VK_REC *METHOD(ValueIterator, iternext);
 END_CLASS
 

trunk/python2/regfi/regfi.c

@@ -30 +30 @@
 
   if(!self->reg) {
-    /*RaiseError(ERuntimeError, "REGFI Error: %s", regfi_log_get_str());*/
+    RaiseError(ERuntimeError, "REGFI Error: %s", regfi_log_get_str());
     /*char* e = regfi_log_get_str();*/
     /*fprintf(stderr, "%p\n", e);*/
@@ -61 +61 @@
 }
 
-static KeyIterator KeyIterator_Con(KeyIterator self, RegistryFile file, char **path,
-                             REGFI_ENCODING encoding) {
+static KeyIterator KeyIterator_Con(KeyIterator self, 
+                                   RegistryFile file, 
+                                   char **path,
+                                   REGFI_ENCODING encoding) 
+{
   self->iter = regfi_iterator_new(file->reg, encoding);
 
@@ -80 +83 @@
   }
 
-  fprintf(stderr, "Con called\n");
-  self->first_called = false;
+  self->root_traversed = false;
 
   return self;
@@ -88 +90 @@
 }
 
-static KeyIterator KeyIterator__iter__(KeyIterator self) {
-  return self;
-}
-
-
-static const REGFI_NK_REC* KeyIterator_next(KeyIterator self) {
-
-  fprintf(stderr, "next called\n");
-
-  if(!self->first_called)
+static void KeyIterator__iter__(KeyIterator self) 
+{
+  return;
+}
+
+
+static const REGFI_NK_REC *KeyIterator_next(KeyIterator self) 
+{
+  if(!self->root_traversed)
+    self->root_traversed = true;
+  else if(!regfi_iterator_down(self->iter))
   {
-    regfi_iterator_first_subkey(self->iter);
-    self->first_called = true;
-  }
-  else
-    regfi_iterator_next_subkey(self->iter);
-    
-  return regfi_iterator_cur_subkey(self->iter);
+    do
+    {
+      if(!regfi_iterator_up(self->iter))
+        return NULL;
+    } while(!regfi_iterator_next_subkey(self->iter));
+
+    /* XXX: This is an error condition.  
+     *      Probably should throw an exception or something. */
+    if(!regfi_iterator_down(self->iter))
+      return NULL;
+  }
+
+  regfi_iterator_first_subkey(self->iter);
+  return regfi_iterator_cur_key(self->iter);
 }
 
 
 static int KeyIterator_down(KeyIterator self) {
-  fprintf(stderr, "down cur_subkey: %d\n", self->iter->cur_subkey);
   int result = regfi_iterator_down(self->iter);
-  fprintf(stderr, "down result: %d\n", result);
   regfi_iterator_first_subkey(self->iter);
   regfi_iterator_first_value(self->iter);
@@ -153 +161 @@
 }
 
-static ValueIterator ValueIterator__iter__(ValueIterator self) {
-  return self;
-}
-
-static RawData ValueIterator_iternext(ValueIterator self) {
+static void ValueIterator__iter__(ValueIterator self) {
+  return;
+}
+
+static REGFI_VK_REC* ValueIterator_iternext(ValueIterator self) {
   RawData result;
   const REGFI_DATA* data;
@@ -172 +180 @@
   rec = regfi_iterator_cur_value(self->iter);
 
+  return rec;
+
   if(!rec) return NULL;
 
@@ -177 +187 @@
    *      Instead, make data fetching a method and parse it then. 
    */
+  /*
   data = (REGFI_DATA *)regfi_iterator_fetch_data(self->iter, rec);
   if(!data) {
@@ -198 +209 @@
     break;
   }
+  */
 
   return result;